fix: ci's and scanpy 1.13 plot compat - #1253
Open
selmanozleyen wants to merge 6 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1253 +/- ##
==========================================
- Coverage 77.24% 77.21% -0.04%
==========================================
Files 63 63
Lines 9378 9396 +18
Branches 1579 1579
==========================================
+ Hits 7244 7255 +11
- Misses 1532 1539 +7
Partials 602 602
🚀 New features to boost your workflow:
|
selmanozleyen
marked this pull request as ready for review
August 5, 2026 10:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves compatibility with recent Scanpy releases, refactors how plotting palettes are imported, and reorganizes experimental plotting tests. It also adjusts test execution in pre-release environments to avoid failures due to external dependencies.
Scanpy compatibility and palette import refactor:
src/squidpy/_compat.pyto use the newscanpy.plotting.legacymodule when available, including fallback logic for older versions. Thedefault_paletteis now also imported via_compat.pyand re-exported for use elsewhere.src/squidpy/im/_container.pyto importdefault_palettefromsquidpy._compatinstead of directly from Scanpy, ensuring consistent palette usage regardless of Scanpy version.Test organization and execution:
tests/experimental/test_stain_normalize.pyto a new file,tests/experimental/plotting/test_stain_normalize.py, and updated imports accordingly. [1] [2] [3] [4]hatch.tomlto skip running the experimental plotting tests in pre-release environments, preventing unrelated failures due to upstream changes inspatialdata-plot.